Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase space between links in right sidebar to match left sidebar #1980

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented Sep 12, 2024

For this PR, I compared the line height, font size and weight, and vertical white space between the entries in the table of contents on the left (the section table of contents) and entries in the tables of contents on the right (the "on this page" table of contents). The only discrepancy I found was that the left TOC had padding top and bottom set to 0.25rem, whereas the right TOC had top and bottom padding set to 0.125rem.

This PR increases the padding on the right to match the left. It creates a new Sass variable and uses that variable to set top and bottom padding on both sides to 0.25rem.

Closes external issue:

@gabalafou gabalafou force-pushed the increase-spacing-on-this-page-toc branch from 9a84931 to 3f3fe38 Compare September 12, 2024 16:37
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks much better now

@trallard trallard merged commit 7e20e75 into pydata:main Sep 18, 2024
25 checks passed
@gabalafou gabalafou deleted the increase-spacing-on-this-page-toc branch September 19, 2024 15:05
gabalafou added a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Oct 6, 2024
@Carreau Carreau added this to the Empty milestone. milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants